fix: skill upload constraints, rejected label, and last-version guard#82
Merged
yun-zhi-ztl merged 22 commits intomainfrom Mar 18, 2026
Merged
fix: skill upload constraints, rejected label, and last-version guard#82yun-zhi-ztl merged 22 commits intomainfrom
yun-zhi-ztl merged 22 commits intomainfrom
Conversation
The resolveStatusLabel and resolveStatusClassName functions were missing the REJECTED case, causing rejected skills to show raw status string with no color styling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Backend: added version count check in SkillGovernanceService.deleteVersion() Frontend: hide delete button when only one version remains Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix deleteVersion_removesDraftFilesAndBundle: mock findBySkillId to return 2 versions so the new guard doesn't block the happy path - Add deleteVersion_rejectsLastRemainingVersion: verify that deleting the only remaining version is rejected with the correct error code
vsxd
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1. Relax Skill Upload Constraints
SkillPackageArchiveExtractorto use injectedSkillPublishProperties2. Add REJECTED Status Label on My Skills Page
resolveStatusLabelandresolveStatusClassNamewere missing theREJECTEDcase.status-pill--rejectedCSS class (red background)3. Prevent Deleting the Last Remaining Version
SkillGovernanceService.deleteVersion()now checks version count and rejects deletion when only one version remains (error.skill.version.delete.lastVersion)Tests